Skip to content

Commit

Permalink
hostfs: fix memory handling in follow_link()
Browse files Browse the repository at this point in the history
1) argument should not be freed in any case - the caller already has
it as ->s_fs_info (and uses it a lot afterwards)
2) allocate readlink buffer with kmalloc() - the caller has no way
to tell if it's got that (on absolute symlink) or a result of
kasprintf().  Sure, for SLAB and SLUB kfree() works on results of
kmem_cache_alloc(), but that's not documented anywhere, might change
in the future *and* is already not true for SLOB.

Fixes: 52b209f ("get rid of hostfs_read_inode()")
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Mar 25, 2021
1 parent a38fd87 commit 7f6c411
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions fs/hostfs/hostfs_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ static char *follow_link(char *link)
char *name, *resolved, *end;
int n;

name = __getname();
name = kmalloc(PATH_MAX, GFP_KERNEL);
if (!name) {
n = -ENOMEM;
goto out_free;
Expand Down Expand Up @@ -173,12 +173,11 @@ static char *follow_link(char *link)
goto out_free;
}

__putname(name);
kfree(link);
kfree(name);
return resolved;

out_free:
__putname(name);
kfree(name);
return ERR_PTR(n);
}

Expand Down

0 comments on commit 7f6c411

Please sign in to comment.