qnx4_lookup: use d_splice_alias()

code is simpler that way Acked-by: Anders Larsen <[email protected]> Signed-off-by: Al Viro <[email protected]>
fracktal · May 22, 2018 · b135dce · b135dce
1 parent b014951
commit b135dce
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/fs/qnx4/namei.c b/fs/qnx4/namei.c
@@ -114,13 +114,9 @@ struct dentry * qnx4_lookup(struct inode *dir, struct dentry *dentry, unsigned i
 	brelse(bh);
 
 	foundinode = qnx4_iget(dir->i_sb, ino);
-	if (IS_ERR(foundinode)) {
+	if (IS_ERR(foundinode))
 		QNX4DEBUG((KERN_ERR "qnx4: lookup->iget -> error %ld\n",
 			   PTR_ERR(foundinode)));
-		return ERR_CAST(foundinode);
-	}
 out:
-	d_add(dentry, foundinode);
-
-	return NULL;
+	return d_splice_alias(foundinode, dentry);
 }