Skip to content

Commit

Permalink
coccinnelle: Remove ptr_ret script
Browse files Browse the repository at this point in the history
The ptr_ret script script addresses a number of situations where we end up
testing an error pointer, and if it's an error returning it, or return 0
otherwise to transform it into a PTR_ERR_OR_ZERO call.

So it will convert a block like this:

if (IS_ERR(err))
    return PTR_ERR(err);

return 0;

into

return PTR_ERR_OR_ZERO(err);

While this is technically correct, it has a number of drawbacks. First, it
merges the error and success path, which will make it harder for a reviewer
or reader to grasp.

It's also more difficult to extend if we were to add some code between the
error check and the function return, making the author essentially revert
that patch before adding new lines, while it would have been a trivial
addition otherwise for the rewiever.

Therefore, since that script is only about cosmetic in the first place,
let's remove it since it's not worth it.

Acked-by: Jani Nikula <[email protected]>
Acked-by: Thierry Reding <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Reviewed-by: Wolfram Sang <[email protected]>
Reviewed-by: Mark Brown <[email protected]>
Signed-off-by: Maxime Ripard <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
  • Loading branch information
mripard authored and JuliaLawall committed Dec 15, 2020
1 parent 33114c4 commit b784c77
Showing 1 changed file with 0 additions and 97 deletions.
97 changes: 0 additions & 97 deletions scripts/coccinelle/api/ptr_ret.cocci

This file was deleted.

0 comments on commit b784c77

Please sign in to comment.