Skip to content

Commit

Permalink
drm/panel-simple: Fix inverted V/H SYNC for Frida FRD350H54004 panel
Browse files Browse the repository at this point in the history
The FRD350H54004 panel was marked as having active-high VSYNC and HSYNC
signals, which sorts-of worked, but resulted in the picture fading out
under certain circumstances.

Fix this issue by marking VSYNC and HSYNC signals active-low.

v2: Rebase on drm-misc-next

Fixes: 7b6bd84 ("drm/panel: simple: Add support for the Frida FRD350H54004 panel")
Cc: [email protected] # v5.5
Signed-off-by: Paul Cercueil <[email protected]>
Signed-off-by: Sam Ravnborg <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
pcercuei authored and sravnborg committed Jul 16, 2020
1 parent 947fcfe commit bad20a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/panel/panel-simple.c
Original file line number Diff line number Diff line change
Expand Up @@ -1763,7 +1763,7 @@ static const struct drm_display_mode frida_frd350h54004_mode = {
.vsync_start = 240 + 2,
.vsync_end = 240 + 2 + 6,
.vtotal = 240 + 2 + 6 + 2,
.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
};

static const struct panel_desc frida_frd350h54004 = {
Expand Down

0 comments on commit bad20a2

Please sign in to comment.