ext4: fix an IS_ERR() vs NULL check

The ext4_find_extent() function never returns NULL, it returns error pointers. Fixes: 44059e5 ("ext4: fast commit recovery path") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Jan Kara <[email protected]> Link: https://lore.kernel.org/r/20201023112232.GB282278@mwanda Signed-off-by: Theodore Ts'o <[email protected]> Cc: [email protected]
fracktal · Dec 17, 2020 · bc18546 · bc18546
1 parent c920076
commit bc18546
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
@@ -5815,8 +5815,8 @@ int ext4_ext_replay_update_ex(struct inode *inode, ext4_lblk_t start,
 	int ret;
 
 	path = ext4_find_extent(inode, start, NULL, 0);
-	if (!path)
-		return -EINVAL;
+	if (IS_ERR(path))
+		return PTR_ERR(path);
 	ex = path[path->p_depth].p_ext;
 	if (!ex) {
 		ret = -EFSCORRUPTED;