Skip to content

Commit

Permalink
cxgb4: Add missing annotation for service_ofldq()
Browse files Browse the repository at this point in the history
Sparse reports a warning at service_ofldq()

warning: context imbalance in service_ofldq() - unexpected unlock

The root cause is the missing annotation at service_ofldq()

Add the missing __must_hold(&q->sendq.lock) annotation

Signed-off-by: Jules Irenge <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
irenge authored and davem330 committed May 1, 2020
1 parent 709e715 commit cae9566
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/chelsio/cxgb4/sge.c
Original file line number Diff line number Diff line change
Expand Up @@ -2728,6 +2728,7 @@ static void ofldtxq_stop(struct sge_uld_txq *q, struct fw_wr_hdr *wr)
* is ever running at a time ...
*/
static void service_ofldq(struct sge_uld_txq *q)
__must_hold(&q->sendq.lock)
{
u64 *pos, *before, *end;
int credits;
Expand Down

0 comments on commit cae9566

Please sign in to comment.