Skip to content

Commit

Permalink
staging/lustre: remove IOC_LIBCFS_PING_TEST ioctl
Browse files Browse the repository at this point in the history
The ioctl IOC_LIBCFS_PING_TEST has not been used in ages.  The recent
nidstring changes which moved all the nidstring operations from libcfs
to the LNet layer but this ioctl code was still using an nidstring
operation that was causing a circular dependency loop between libcfs and
LNet.

Signed-off-by: James Simmons <[email protected]>
Signed-off-by: Oleg Drokin <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
jamesasimmons authored and torvalds committed Dec 6, 2015
1 parent d8cd93e commit d035e33
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
1 change: 0 additions & 1 deletion drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ struct libcfs_ioctl_handler {
#define IOC_LIBCFS_CLEAR_DEBUG _IOWR('e', 31, long)
#define IOC_LIBCFS_MARK_DEBUG _IOWR('e', 32, long)
#define IOC_LIBCFS_MEMHOG _IOWR('e', 36, long)
#define IOC_LIBCFS_PING_TEST _IOWR('e', 37, long)
/* lnet ioctls */
#define IOC_LIBCFS_GET_NI _IOWR('e', 50, long)
#define IOC_LIBCFS_FAIL_NID _IOWR('e', 51, long)
Expand Down
17 changes: 0 additions & 17 deletions drivers/staging/lustre/lustre/libcfs/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,23 +274,6 @@ static int libcfs_ioctl_int(struct cfs_psdev_file *pfile, unsigned long cmd,
}
break;

case IOC_LIBCFS_PING_TEST: {
extern void (kping_client)(struct libcfs_ioctl_data *);
void (*ping)(struct libcfs_ioctl_data *);

CDEBUG(D_IOCTL, "doing %d pings to nid %s (%s)\n",
data->ioc_count, libcfs_nid2str(data->ioc_nid),
libcfs_nid2str(data->ioc_nid));
ping = symbol_get(kping_client);
if (!ping)
CERROR("symbol_get failed\n");
else {
ping(data);
symbol_put(kping_client);
}
return 0;
}

default: {
struct libcfs_ioctl_handler *hand;

Expand Down

0 comments on commit d035e33

Please sign in to comment.