security: inode: fix a missing check for securityfs_create_file

securityfs_create_file may fail. The fix checks its status and returns the error code upstream if it fails. Signed-off-by: Kangjie Lu <[email protected]> Signed-off-by: James Morris <[email protected]>
fracktal · Apr 10, 2019 · d1a0846 · d1a0846
1 parent 0b9dc6c
commit d1a0846
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/security/inode.c b/security/inode.c
@@ -339,6 +339,11 @@ static int __init securityfs_init(void)
 #ifdef CONFIG_SECURITY
 	lsm_dentry = securityfs_create_file("lsm", 0444, NULL, NULL,
 						&lsm_ops);
+	if (IS_ERR(lsm_dentry)) {
+		unregister_filesystem(&fs_type);
+		sysfs_remove_mount_point(kernel_kobj, "security");
+		return PTR_ERR(lsm_dentry);
+	}
 #endif
 	return 0;
 }