regulator: core: Fix missing error return from regulator_bulk_get()

In commit 6eabfc0 ("regulator: core: Allow specifying an initial load w/ the bulk API") I changed the error handling but had a subtle that caused us to always return no error even if there was an error. Fix it. Fixes: 6eabfc0 ("regulator: core: Allow specifying an initial load w/ the bulk API") Signed-off-by: Douglas Anderson <[email protected]> Link: https://lore.kernel.org/r/20220809142738.1.I91625242f137c707bb345c51c80c5ecee02eeff3@changeid Signed-off-by: Mark Brown <[email protected]>
fracktal · Aug 10, 2022 · d511e8a · d511e8a
1 parent b0de7fa
commit d511e8a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
@@ -4784,10 +4784,10 @@ int regulator_bulk_get(struct device *dev, int num_consumers,
 		consumers[i].consumer = regulator_get(dev,
 						      consumers[i].supply);
 		if (IS_ERR(consumers[i].consumer)) {
-			consumers[i].consumer = NULL;
 			ret = dev_err_probe(dev, PTR_ERR(consumers[i].consumer),
 					    "Failed to get supply '%s'",
 					    consumers[i].supply);
+			consumers[i].consumer = NULL;
 			goto err;
 		}