phy: fixed-phy: properly validate phy in fixed_phy_update_state()

Validate that the phy_device passed into fixed_phy_update_state() is a fixed-phy device before walking the list of phys for a fixed phy at the same address. Signed-off-by: Russell King <[email protected]> Signed-off-by: David S. Miller <[email protected]>
fracktal · Sep 25, 2015 · d618bf2 · d618bf2
1 parent 04d53b2
commit d618bf2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
@@ -220,7 +220,7 @@ int fixed_phy_update_state(struct phy_device *phydev,
 	struct fixed_mdio_bus *fmb = &platform_fmb;
 	struct fixed_phy *fp;
 
-	if (!phydev || !phydev->bus)
+	if (!phydev || phydev->bus != fmb->mii_bus)
 		return -EINVAL;
 
 	list_for_each_entry(fp, &fmb->phys, node) {