-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved INFO_RESOURCES access to instance get method #47
Conversation
Thanks for the pr! Please make sure all tests passes and I'll be happy to merge this. |
Please rebase and make sure that all tests complete. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 55.32% 55.05% -0.27%
==========================================
Files 11 11
Lines 817 821 +4
==========================================
Hits 452 452
- Misses 365 369 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@fredrike - thanks for fixing and landing this! sorry I wasn't able to get to this the past few months. |
In pydaikin/daikin_brp069.py INFO_RESOURCES is modified on init but meant to be a constant. If init is called multiple times this will cause the list of resources to grow.
I've split out access of info resources to an instance method to allow modification per instance based on state.
This fixes #46