Правки по спринту 16 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilaG
reviewed
Sep 12, 2024
|
|
||
| import Foundation | ||
|
|
||
| final class ChooseCategoryViewModel { |
There was a problem hiding this comment.
Было бы классно закрыть все view models протоколами, это бы повысило тестируемость кода
Tracker/Constants.swift
Outdated
|
|
||
| typealias Binding<T> = (T) -> Void | ||
|
|
||
| import Foundation |
There was a problem hiding this comment.
Обычно, импорты указывают выше всего кода, в том числе и typealias-ов
Comment on lines
+29
to
+35
| private lazy var pages: [UIViewController] = { | ||
| let screen1 = OnboardingScreenViewController(backgroundImageString: screen1BackImageString, screenTextString: screen1LabelString) | ||
|
|
||
| let screen2 = OnboardingScreenViewController(backgroundImageString: screen2BackImageString, screenTextString: screen2LabelString) | ||
|
|
||
| return [screen1, screen2] | ||
| }() |
There was a problem hiding this comment.
можно упростить:
private var pages: [UIViewController] = [
OnboardingScreenViewController(
backgroundImageString: "Отслеживайте только то, что хотите",
screenTextString: "onboardingBack1"
),
OnboardingScreenViewController(
backgroundImageString: "Даже если это не литры воды и йога",
screenTextString: "onboardingBack2"
)
]
Если же охото сохранить строки в именнованные константы, то их можно сделать статик, тогда не придётся делать лейзи массив
|
|
||
| // MARK: - UIPageViewControllerDataSource | ||
|
|
||
| func pageViewController(_ pageViewController: UIPageViewController, viewControllerBefore viewController: UIViewController) -> UIViewController? { |
There was a problem hiding this comment.
Обычно, сначало идут не приватные методы - затем приватные)
Иногда подчинение какому-либо протоколу выносят в extension, и тогда не приватные методы находятся в нём, но по коду ниже приватных
DanilaG
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.