Specify version when installing WiX #1088
Open
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update our CI job and build instructions with the latest WiX version, so that we don't encounter any installation issues when new WiX versions are released. Also, add a reminder in our release instruction to bump the WiX version before we start a new release. Fixes #1087
almet
approved these changes
Mar 10, 2025
| @@ -10,6 +10,7 @@ Here is a list of tasks that should be done before issuing the release: | |||
| You can generate its content with the the `poetry run ./dev_scripts/generate-release-tasks.py` command. | |||
| - [ ] [Add new Linux platforms and remove obsolete ones](https://github.com/freedomofpress/dangerzone/blob/main/RELEASE.md#add-new-linux-platforms-and-remove-obsolete-ones) | |||
| - [ ] Bump the Python dependencies using `poetry lock` | |||
| - [ ] Check for new [WiX releases](https://github.com/wixtoolset/wix/releases) | |||
There was a problem hiding this comment.
Maybe add here
Suggested change
| - [ ] Check for new [WiX releases](https://github.com/wixtoolset/wix/releases) | |
| - [ ] Check for new [WiX releases](https://github.com/wixtoolset/wix/releases) and update it if needed |
| @@ -478,13 +478,13 @@ poetry shell | |||
| Install [.NET SDK](https://dotnet.microsoft.com/en-us/download) version 6 or later. Then, open a terminal and install the latest version of [WiX Toolset .NET tool](https://wixtoolset.org/) **v5** with: | |||
|
|
|||
| ```sh | |||
| dotnet tool install --global wix --version 5.* | |||
| dotnet tool install --global wix --version 5.0.2 | |||
There was a problem hiding this comment.
The more I think about it, the more I start the believe this should just be a script that we provide, that should run on windows, rather than a text that we copy/paste.
Probably not for this PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our CI job and build instructions with the latest WiX version, so that we don't encounter any installation issues when new WiX versions are released.
Also, add a reminder in our release instruction to bump the WiX version before we start a new release.
Fixes #1087