Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addChild() and other functions with similar bugs #8

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Conversation

fremail
Copy link
Owner

@fremail fremail commented Apr 17, 2019

Fixes #7

fremail added 3 commits April 18, 2019 00:24
…ldOf, insertAsNextSiblingOf, insertAsPrevSiblingOf, updateNode, shiftRlValues, shiftRlRange

Deeply clone options in functions
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #8 into master will increase coverage by 6.6%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #8     +/-   ##
=========================================
+ Coverage   42.24%   48.84%   +6.6%     
=========================================
  Files           1        2      +1     
  Lines         419      434     +15     
=========================================
+ Hits          177      212     +35     
+ Misses        242      222     -20
Impacted Files Coverage Δ
index.js 47.87% <52.5%> (+5.63%) ⬆️
helpers.js 90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a89b6...b4461d2. Read the comment docs.

@fremail fremail merged commit 91acfbe into master Apr 17, 2019
@fremail fremail deleted the fix-addChild branch April 17, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot insert the node that has its place in the tree
1 participant