Skip to content

Commit

Permalink
- Fix popover behaviour
Browse files Browse the repository at this point in the history
  • Loading branch information
Rustem Mussabekov committed Aug 26, 2019
1 parent e8c4864 commit 58fce1e
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 8 deletions.
2 changes: 1 addition & 1 deletion internals/buildversion.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
482
497
13 changes: 12 additions & 1 deletion internals/manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ var m = {
}

return temp;
},

permissions: function(value) {
let temp = [...value]

//Firefox do not support 'activeTab' as expected
if (global.platform == "firefox")
temp = temp.map(v=>v=='activeTab' ? 'tabs' : v)

return temp
}
}

Expand All @@ -103,6 +113,7 @@ module.exports = {
case "content_security_policy": value = m.contentSecurity(value); break;
case "browser_action": value = m.browserAction(value); break;
case "commands": value = m.commands(value); break;
case "permissions": value = m.permissions(value); break;
}

return value;
Expand Down Expand Up @@ -136,7 +147,7 @@ module.exports = {
plugins.push(
new GenerateJsonPlugin(
'_locales/'+code+"/messages.json", {
appName: keyVal("Raindrop.io: "+t("saveButtonForWeb")),
appName: keyVal("Raindrop.io"),
appDesc: keyVal(t("saveButtonForWeb")),
hotkey: keyVal(t("helpHotKey")),

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "Clipper",
"name": "clipper",
"version": "6.0.0",
"main": "src/index.js",
"license": "MIT",
Expand Down
9 changes: 4 additions & 5 deletions src/background/browserActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ const button = {
},*/

render() {
getCurrentTab((tab)=>{
if (!tab) return;
if (!tab.url) return;
getCurrentTab((tab={})=>{
const { url='' } = tab

var isAppBuild = false;
//Is AppBuild
Expand All @@ -42,13 +41,13 @@ const button = {

var /*buttonIcon="",*/buttonBadge="", buttonPopup="", buttonTitle="";

if ((isNewTabPage(tab.url))&&(!isAppBuild)) {
if ((isNewTabPage(url))&&(!isAppBuild)) {
//Open Raindrop.io
//buttonIcon = button.icons["idle"]
buttonTitle = extension.i18n.getMessage("open")+" Raindrop.io"
}
else{
var status = links.getStatus(tab.url);
var status = links.getStatus(url);
if (status == 'saved')
buttonBadge = '★'
//buttonIcon = button.icons[status];
Expand Down

0 comments on commit 58fce1e

Please sign in to comment.