Correctly check computed property names in type-space get/set accesso…

…rs (microsoft#47156)

* Add test that should fail

* Make it fail

Fixes microsoft#47146

* Baselines

src/compiler/checker.ts

@@ -27089,7 +27089,8 @@ namespace ts {
             const links = getNodeLinks(node.expression);
             if (!links.resolvedType) {
                 if ((isTypeLiteralNode(node.parent.parent) || isClassLike(node.parent.parent) || isInterfaceDeclaration(node.parent.parent))
-                    && isBinaryExpression(node.expression) && node.expression.operatorToken.kind === SyntaxKind.InKeyword) {
+                    && isBinaryExpression(node.expression) && node.expression.operatorToken.kind === SyntaxKind.InKeyword
+                    && node.parent.kind !== SyntaxKind.GetAccessor && node.parent.kind !== SyntaxKind.SetAccessor) {
                     return links.resolvedType = errorType;
                 }
                 links.resolvedType = checkExpression(node.expression);

tests/baselines/reference/noMappedGetSet.errors.txt

@@ -0,0 +1,16 @@
+tests/cases/compiler/noMappedGetSet.ts(2,9): error TS2464: A computed property name must be of type 'string', 'number', 'symbol', or 'any'.
+tests/cases/compiler/noMappedGetSet.ts(2,10): error TS2304: Cannot find name 'K'.
+tests/cases/compiler/noMappedGetSet.ts(2,15): error TS2304: Cannot find name 'WAT'.
+
+
+==== tests/cases/compiler/noMappedGetSet.ts (3 errors) ====
+    type OH_NO = {
+        get [K in WAT](): string
+            ~~~~~~~~~~
+!!! error TS2464: A computed property name must be of type 'string', 'number', 'symbol', or 'any'.
+             ~
+!!! error TS2304: Cannot find name 'K'.
+                  ~~~
+!!! error TS2304: Cannot find name 'WAT'.
+    };
+

tests/baselines/reference/noMappedGetSet.js

@@ -0,0 +1,7 @@
+//// [noMappedGetSet.ts]
+type OH_NO = {
+    get [K in WAT](): string
+};
+
+
+//// [noMappedGetSet.js]

tests/baselines/reference/noMappedGetSet.symbols

@@ -0,0 +1,9 @@
+=== tests/cases/compiler/noMappedGetSet.ts ===
+type OH_NO = {
+>OH_NO : Symbol(OH_NO, Decl(noMappedGetSet.ts, 0, 0))
+
+    get [K in WAT](): string
+>[K in WAT] : Symbol([K in WAT], Decl(noMappedGetSet.ts, 0, 14))
+
+};
+

tests/baselines/reference/noMappedGetSet.types

@@ -0,0 +1,12 @@
+=== tests/cases/compiler/noMappedGetSet.ts ===
+type OH_NO = {
+>OH_NO : OH_NO
+
+    get [K in WAT](): string
+>[K in WAT] : string
+>K in WAT : boolean
+>K : any
+>WAT : any
+
+};
+

tests/cases/compiler/noMappedGetSet.ts

@@ -0,0 +1,3 @@
+type OH_NO = {
+    get [K in WAT](): string
+};