fix Performance/ReverseEach issue

Change-Id: I939e883124ebcd67d57febc7dde6336db6277f62
fixes: CNVS-20009
Reviewed-on: https://gerrit.instructure.com/52893
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <[email protected]>
Product-Review: Strand McCutchen <[email protected]>
QA-Review: Strand McCutchen <[email protected]>

app/controllers/lti/ims/tool_setting_controller.rb

@@ -64,7 +64,7 @@ def tool_setting_json(tool_setting, bubble)
           elsif bubble == 'distinct' && request.headers['accept'].include?('application/vnd.ims.lti.v2.toolsettings.simple+json')
             @content_type = 'application/vnd.ims.lti.v2.toolsettings.simple+json'
             custom = {}
-            graph.reverse.each { |tool_setting| custom.merge!(tool_setting.custom) }
+            graph.reverse_each { |tool_setting| custom.merge!(tool_setting.custom) }
             custom
           end
         else

app/models/account/settings.rb

@@ -31,7 +31,7 @@ def self.included(klass)
   # otherwise use the last explicitly set value
   def calculate_inherited_setting(setting)
     inherited_hash = {:locked => false, :value => self.class.account_settings_options[setting][:default]}
-    self.account_chain.reverse.each do |acc|
+    self.account_chain.reverse_each do |acc|
       current_hash = acc.settings[setting]
       next if current_hash.nil?
 

app/models/grading_standard.rb

@@ -192,7 +192,7 @@ def destroy
 
   def grading_scheme
     res = {}
-    self.data.sort_by{|_, lower_bound| lower_bound}.reverse.each do |grade_name, lower_bound|
+    self.data.sort_by{|_, lower_bound| lower_bound}.reverse_each do |grade_name, lower_bound|
       res[grade_name] = lower_bound.to_f
     end
     res

app/models/quizzes/quiz_question_data_fixer.rb

@@ -52,7 +52,7 @@ def self.is_valid_data(data)
   end
 
   def self.find_good_data(aq)
-    aq.versions.sort_by { |v| v.number }.reverse.each do |version|
+    aq.versions.sort_by { |v| v.number }.reverse_each do |version|
       data = version.model.question_data
       return data if is_valid_data(data)
     end

app/models/quizzes/quiz_submission.rb

@@ -449,7 +449,7 @@ def scores_for_versions(exclude_version_id)
     scores[attempt] = self.score if self.score
 
     # only most recent version for each attempt - some have regraded a version
-    versions.sort_by(&:number).reverse.each do |ver|
+    versions.sort_by(&:number).reverse_each do |ver|
       scores[ver.model.attempt] ||= ver.model.score || 0.0
     end
 

app/models/submission.rb

@@ -609,7 +609,7 @@ def check_for_media_object
   def submission_history
     res = []
     last_submitted_at = nil
-    self.versions.sort_by(&:created_at).reverse.each do |version|
+    self.versions.sort_by(&:created_at).reverse_each do |version|
       model = version.model
       if model.submitted_at && last_submitted_at.to_i != model.submitted_at.to_i
         res << model

gems/canvas_panda_pub/lib/canvas_panda_pub/async_worker.rb

@@ -84,7 +84,7 @@ def run_thread
         # future flexibility for adding more modes (like pushing all updates,
         # instead of just the most recent).
         seen_channels = Set.new
-        work.reverse.each do |ary|
+        work.reverse_each do |ary|
           if seen_channels.include? ary[0]
             ary[2] = false
           else

gems/plugins/qti_exporter/lib/qti/assessment_item_converter.rb

@@ -327,7 +327,7 @@ def sanitize_html!(node, remove_extraneous_nodes=false)
           child.remove
         end
 
-        node.children.reverse.each do |child|
+        node.children.reverse_each do |child|
           break unless child.text? && child.text =~ /\A\s+\z/ || child.element? && child.name.downcase == 'br'
           child.remove
         end

lib/api/v1/avatar.rb

@@ -26,7 +26,7 @@ def avatars_json_for_user(user, includes={})
       :type => 'gravatar',
       :alt => 'gravatar pic'
     })
-    user.profile_pics_folder.active_file_attachments({:include => :thumbnail}).select{|a| a.content_type.match(/\Aimage\//) && a.thumbnail}.sort_by(&:id).reverse.each do |image|
+    user.profile_pics_folder.active_file_attachments({:include => :thumbnail}).select{|a| a.content_type.match(/\Aimage\//) && a.thumbnail}.sort_by(&:id).reverse_each do |image|
       avatars << avatar_json(user, image, {
         :type => 'attachment',
         :alt => image.display_name,

lib/gradebook_importer.rb

@@ -126,7 +126,7 @@ def parse!
           submission['original_grade'].to_s == submission['grade'] || (submission['original_grade'].blank? && submission['grade'].blank?)
         end
       end
-      indexes_to_delete.reverse.each do |idx|
+      indexes_to_delete.reverse_each do |idx|
         @assignments.delete_at(idx)
         @students.each do |student|
           student.gradebook_importer_submissions.delete_at(idx)

spec/migrations/remove_multiple_root_folders_spec.rb

@@ -54,7 +54,7 @@ def get_root_folder_name(context)
         subfolders = subfolders.map(&:sub_folders).flatten
         folders.concat(subfolders)
       end
-      folders.reverse.each { |f| Folder.where(id: f).delete_all }
+      folders.reverse_each { |f| Folder.where(id: f).delete_all }
       c.enrollment_terms.scoped.delete_all if c.is_a?(Account)
       c.course_account_associations.scoped.delete_all if c.is_a?(Course)
       c.delete