Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates things to fall more in line with post-2018-edition rust along with some small cleanup
I believe that I avoided any unnecessary breaking changes. The only difficult part was dealing with
TryInto<reqwest::Url, Error = crate::Error>
which worked when using the library'sTryInto
implementation, but can't work withstd
's because of the orphan rule. Switching toreqwest::Url
should accept the same values and still can bubble the error up to acrate::Error
thoughI also removed the
#![cfg_attr(test, deny(warnings))]
since it's a bit annoying for my workflow where I generally use a program to watch the source files and run tests when it sees a file changed (using bacon while another good alternative is cargo-watch). It's a bit cumbersome to not be able to easily differentiate between warnings and errors when working like this and I don't think it's a big issue since warnings are denied in CI