Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2018 edition #33

Merged
merged 8 commits into from
Nov 21, 2021

Conversation

CosmicHorrorDev
Copy link
Collaborator

This updates things to fall more in line with post-2018-edition rust along with some small cleanup

I believe that I avoided any unnecessary breaking changes. The only difficult part was dealing with TryInto<reqwest::Url, Error = crate::Error> which worked when using the library's TryInto implementation, but can't work with std's because of the orphan rule. Switching to reqwest::Url should accept the same values and still can bubble the error up to a crate::Error though

I also removed the #![cfg_attr(test, deny(warnings))] since it's a bit annoying for my workflow where I generally use a program to watch the source files and run tests when it sees a file changed (using bacon while another good alternative is cargo-watch). It's a bit cumbersome to not be able to easily differentiate between warnings and errors when working like this and I don't think it's a big issue since warnings are denied in CI

@CosmicHorrorDev
Copy link
Collaborator Author

I decided to temporarily allow warnings in CI until the deprecation notices from using error_chain get sorted out

Copy link
Contributor

@compressed compressed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@compressed compressed merged commit b44ca0e into frostly:master Nov 21, 2021
@compressed
Copy link
Contributor

Also agree on the #![cfg_attr(test, deny(warnings))] point. I use cargo-watch heavily so I can see how this would be annoying. The intent was there before, but not needed now.

ch3ck pushed a commit to ch3ck/rusty-slack that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants