Make SetRecordMessageLevel return void.

SetRecordMessageLevel does not need the previous level to be restored.
fujunwei · Apr 7, 2022 · f7e4931 · f7e4931
1 parent 1049215
commit f7e4931
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/gpgmm/Debug.cpp b/src/gpgmm/Debug.cpp
@@ -20,10 +20,8 @@ namespace gpgmm {
     // Messages with equal or greater to severity will be logged.
     LogSeverity gRecordEventLevel = LogSeverity::Info;
 
-    LogSeverity SetRecordMessageLevel(const LogSeverity& newLevel) {
-        LogSeverity oldLevel = gRecordEventLevel;
+    void SetRecordMessageLevel(const LogSeverity& newLevel) {
         gRecordEventLevel = newLevel;
-        return oldLevel;
     }
 
     void RecordMessage(const LogSeverity& severity,

diff --git a/src/gpgmm/Debug.h b/src/gpgmm/Debug.h
@@ -54,8 +54,7 @@ namespace gpgmm {
     } while (false)
 
     // Messages of a given severity to be recorded.
-    // Set the new level and returns the previous level so it may be restored by the caller.
-    LogSeverity SetRecordMessageLevel(const LogSeverity& level);
+    void SetRecordMessageLevel(const LogSeverity& level);
 
     void RecordMessage(const LogSeverity& severity,
                        const char* name,