Forbid duplicate keys in dictionary literals

RELNOTES: When using the dictionary literal syntax, it is now an error to have duplicated keys (e.g. {'ab': 3, 'ab': 5}). PiperOrigin-RevId: 167750614
fulldecent · Sep 7, 2017 · 35e0c2d · 35e0c2d
1 parent c31f696
commit 35e0c2d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/site/docs/skylark/backward-compatibility.md b/site/docs/skylark/backward-compatibility.md
@@ -219,7 +219,7 @@ If you really want to override a value, use a separate statement:
 `mydict["a"] = 4`.
 
 *   Flag: `--incompatible_dict_literal_has_no_duplicates`
-*   Default: `false`
+*   Default: `true`
 
 
 ## Checked arithmetic

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemanticsOptions.java
@@ -190,7 +190,7 @@ public class SkylarkSemanticsOptions extends OptionsBase implements Serializable
 
   @Option(
     name = "incompatible_dict_literal_has_no_duplicates",
-    defaultValue = "false",
+    defaultValue = "true",
     category = "incompatible changes",
     documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
     effectTags = {OptionEffectTag.UNKNOWN},