Rename 'executable' argument of 'ctx.actions.expand_template' to 'is_…

…executable'. This is for consistency with 'ctx.actions.write'. RELNOTES: None. PiperOrigin-RevId: 163687973
fulldecent · Jul 31, 2017 · a4bfe16 · a4bfe16
1 parent eb270a6
commit a4bfe16
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/SkylarkActionFactory.java b/src/main/java/com/google/devtools/build/lib/rules/SkylarkActionFactory.java
@@ -669,7 +669,7 @@ private static String mangleMnemonic(String mnemonic) {
         doc = "substitutions to make when expanding the template."
       ),
       @Param(
-        name = "executable",
+        name = "is_executable",
         type = Boolean.class,
         defaultValue = "False",
         named = true,

diff --git a/...st/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/...st/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java
@@ -633,7 +633,7 @@ public void testCreateTemplateAction() throws Exception {
         "  template = ruleContext.files.srcs[0],",
         "  output = ruleContext.files.srcs[1],",
         "  substitutions = {'a': 'b'},",
-        "  executable = False)");
+        "  is_executable = False)");
 
     TemplateExpansionAction action = (TemplateExpansionAction) Iterables.getOnlyElement(
         ruleContext.getRuleContext().getAnalysisEnvironment().getRegisteredActions());
@@ -669,7 +669,7 @@ public void testCreateTemplateActionWithWrongEncoding() throws Exception {
         "  template = ruleContext.files.srcs[0],",
         "  output = ruleContext.files.srcs[1],",
         "  substitutions = {'a': '" + new String(bytesToDecode, latin1) + "'},",
-        "  executable = False)");
+        "  is_executable = False)");
     TemplateExpansionAction action = (TemplateExpansionAction) Iterables.getOnlyElement(
         ruleContext.getRuleContext().getAnalysisEnvironment().getRegisteredActions());
     List<Substitution> substitutions = action.getSubstitutions();