Skip to content

Commit

Permalink
qmake: Don't warn about using private headers if there are none
Browse files Browse the repository at this point in the history
Change-Id: I1d9ab0b4d25671931faa469e66cb2beb7bd846fd
Reviewed-by: Alexandru Croitor <[email protected]>
  • Loading branch information
torarnv committed Oct 23, 2020
1 parent addd3b5 commit 4485f0d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions mkspecs/features/qt.prf
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ defineTest(qtProcessModuleFlags) {
export($$1)
}

unset(using_privates)
unset(using_private_headers)
var_sfx =
for(ever) {
# Topological resolution of modules based on their QT.<module>.depends variable
Expand All @@ -190,8 +190,8 @@ for(ever) {
next()
}

contains(MODULE_CONFIG, internal_module): \
using_privates = true
contains(MODULE_CONFIG, internal_module):!isEmpty(MODULE_INCLUDES): \
using_private_headers = true
contains(MODULE_CONFIG, ltcg): \
CONFIG += link_ltcg

Expand Down Expand Up @@ -246,7 +246,7 @@ for(ever) {
!isEmpty(var_sfx): break()
var_sfx = _PRIVATE
}
!isEmpty(using_privates):!no_private_qt_headers_warning:!build_pass {
!isEmpty(using_private_headers):!no_private_qt_headers_warning:!build_pass {
message("This project is using private headers and will therefore be tied to this specific Qt module build version.")
message("Running this project against other versions of the Qt modules may crash at any arbitrary point.")
message("This is not a bug, but a result of using Qt internals. You have been warned!")
Expand Down

0 comments on commit 4485f0d

Please sign in to comment.