Skip to content

Commit

Permalink
tst_macdeployqt: fix runVerifyDeployment()
Browse files Browse the repository at this point in the history
QList rather pointlessly has a startsWith() function, which means this
code compiled. But the code makes no sense: it tests the same
condition over and over again, so I'm assuming that it should be
path.startsWith() and not path_s_.startsWith().

Amends 3f56950, but that just
imported the code from qttools. I didn't check whether the bug was
present there, already.

Pick-to: 6.6 6.5
Change-Id: I98a4bbfe0400700655a5c2137f7a976a835a8d28
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Tor Arne Vestbø <[email protected]>
  • Loading branch information
marcmutz committed Aug 8, 2023
1 parent 3498bae commit 52ef958
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/auto/tools/macdeployqt/tst_macdeployqt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ void runVerifyDeployment(const QString &name)
part = part.trimmed();
if (part.isEmpty())
continue;
QVERIFY(!parts.startsWith(qtPath));
QVERIFY(!part.startsWith(qtPath));
}
}

Expand Down

0 comments on commit 52ef958

Please sign in to comment.