Dont' return a const ref to QModelIndex

The conversion operator from QPMI to QModelIndex should return by value, to hide implementation details and so that we don't have to rely on a static empty QModelIndex. Change-Id: I92b3f8451422f2b69bf31f28b387a124fd24ec46 Reviewed-by: Giuseppe D'Angelo <[email protected]> (cherry picked from commit 0cd2935) Reviewed-by: Qt Cherry-pick Bot <[email protected]>
fwcd · Dec 4, 2020 · 57e9d9e · 57e9d9e
1 parent 6012285
commit 57e9d9e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/corelib/itemmodels/qabstractitemmodel.cpp b/src/corelib/itemmodels/qabstractitemmodel.cpp
@@ -488,17 +488,16 @@ QPersistentModelIndex &QPersistentModelIndex::operator=(const QModelIndex &other
 }
 
 /*!
-  \fn QPersistentModelIndex::operator const QModelIndex&() const
+  \fn QPersistentModelIndex::operator QModelIndex() const
 
-  Cast operator that returns a const QModelIndex&.
+  Cast operator that returns a QModelIndex.
 */
 
-QPersistentModelIndex::operator const QModelIndex&() const
+QPersistentModelIndex::operator QModelIndex() const
 {
-    static const QModelIndex invalid;
     if (d)
         return d->index;
-    return invalid;
+    return QModelIndex();
 }
 
 /*!

diff --git a/src/corelib/itemmodels/qabstractitemmodel.h b/src/corelib/itemmodels/qabstractitemmodel.h
@@ -226,7 +226,7 @@ class Q_CORE_EXPORT QPersistentModelIndex
     bool operator==(const QModelIndex &other) const;
     bool operator!=(const QModelIndex &other) const;
     QPersistentModelIndex &operator=(const QModelIndex &other);
-    operator const QModelIndex&() const;
+    operator QModelIndex() const;
     int row() const;
     int column() const;
     void *internalPointer() const;