Skip to content

Commit

Permalink
QDBusServer: Delegate construction to two-argument constructor
Browse files Browse the repository at this point in the history
This reduces code duplication.

Change-Id: Ia637045f9495d68dba41bc146c9ba807f5619c5d
Reviewed-by: Thiago Macieira <[email protected]>
  • Loading branch information
eugmes committed Aug 22, 2023
1 parent a1ab229 commit e073d7d
Showing 1 changed file with 6 additions and 18 deletions.
24 changes: 6 additions & 18 deletions src/dbus/qdbusserver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,27 +51,15 @@ QDBusServer::QDBusServer(const QString &address, QObject *parent)
localhost (elsewhere).
*/
QDBusServer::QDBusServer(QObject *parent)
: QObject(parent), d(nullptr)
{
: QDBusServer(
#ifdef Q_OS_UNIX
// Use Unix sockets on Unix systems only
const QString address = QStringLiteral("unix:tmpdir=/tmp");
// Use Unix sockets on Unix systems only
QStringLiteral("unix:tmpdir=/tmp"),
#else
const QString address = QStringLiteral("tcp:");
QStringLiteral("tcp:"),
#endif

if (!qdbus_loadLibDBus())
return;

QDBusConnectionManager *instance = QDBusConnectionManager::instance();
if (!instance)
return;

instance->createServer(address, this);
Q_ASSERT(d != nullptr);

QObject::connect(d, SIGNAL(newServerConnection(QDBusConnectionPrivate*)),
this, SLOT(_q_newConnection(QDBusConnectionPrivate*)), Qt::QueuedConnection);
parent)
{
}

/*!
Expand Down

0 comments on commit e073d7d

Please sign in to comment.