Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
QCryptographicHash: don't include openssl/sha.h
... it conflicts with rfc6234/sha.h's SHA{1,224,256,384,512} symbols. We can't drop the rfc6234/sha.h header, as openssl/sha.h doesn't give us the algorithm's block sizes, necessary for HMAC (QMessageAuthenticationCode). But we can drop openssl/sha.h. The only reason we included the header was to get access to SHA<N>_DIGEST_LENGTH, but this is a well-known value and easily obtained from rfc6234/sha.h as SHA<N>HashSize, so use that. Even reduces #ifdef'ery. Amends d9f9d03. Fixes: QTBUG-111467 Pick-to: 6.5 Change-Id: Ice19ad8c788fb2828666647cc40abb894cd7af2b Reviewed-by: Fabian Kosmale <[email protected]>
- Loading branch information