use reinterpret_cast instead C-style to load symbols with dlsym to pr…

…event UB
fweimer-rh · May 7, 2020 · c5209eb · c5209eb
1 parent ec41181
commit c5209eb
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/examples/cpp/custom_formula.cpp b/examples/cpp/custom_formula.cpp
@@ -44,7 +44,7 @@ int main() {
         return -1;
     }
     pf_obj *(*pfn)(void);
-    pfn = (pf_obj * (*)(void)) dlsym(lib_handle, "pf_new");
+    pfn = reinterpret_cast<pf_obj * (*)(void)>(dlsym(lib_handle, "pf_new"));
     if (!pfn)
     {
         fprintf(stderr, "Error loading formula symbols: %s", dlerror());

diff --git a/examples/cpp/multithread_mandelbrot.cpp b/examples/cpp/multithread_mandelbrot.cpp
@@ -96,7 +96,7 @@ int main() {
         return -1;
     }
     pf_obj *(*pfn)(void);
-    pfn = (pf_obj * (*)(void)) dlsym(lib_handle, "pf_new");
+    pfn = reinterpret_cast<pf_obj * (*)(void)>(dlsym(lib_handle, "pf_new"));
     if (!pfn)
     {
         fprintf(stderr, "Error loading formula symbols: %s", dlerror());

diff --git a/examples/cpp/raw_mandelbrot.cpp b/examples/cpp/raw_mandelbrot.cpp
@@ -41,7 +41,7 @@ int main() {
         return -1;
     }
     pf_obj *(*pfn)(void);
-    pfn = (pf_obj * (*)(void)) dlsym(lib_handle, "pf_new");
+    pfn = reinterpret_cast<pf_obj * (*)(void)>(dlsym(lib_handle, "pf_new"));
     if (!pfn)
     {
         fprintf(stderr, "Error loading formula symbols: %s", dlerror());

diff --git a/examples/cpp/simple_mandelbrot.cpp b/examples/cpp/simple_mandelbrot.cpp
@@ -39,7 +39,7 @@ int main() {
         return -1;
     }
     pf_obj *(*pfn)(void);
-    pfn = (pf_obj * (*)(void)) dlsym(lib_handle, "pf_new");
+    pfn = reinterpret_cast<pf_obj * (*)(void)>(dlsym(lib_handle, "pf_new"));
     if (!pfn)
     {
         fprintf(stderr, "Error loading formula symbols: %s", dlerror());

diff --git a/fract4d/c/fract4dc/controllers.cpp b/fract4d/c/fract4dc/controllers.cpp
@@ -153,7 +153,7 @@ namespace controllers
 
         // create the point function handler from dynamic library
         pf_obj *(*pfn)(void);
-        pfn = (pf_obj * (*)(void)) dlsym(lib_handle, "pf_new");
+        pfn = reinterpret_cast<pf_obj * (*)(void)>(dlsym(lib_handle, "pf_new"));
         if (!pfn)
         {
             PyErr_SetString(PyExc_ValueError, dlerror());

diff --git a/fract4d/c/fract4dc/loaders.cpp b/fract4d/c/fract4dc/loaders.cpp
@@ -62,7 +62,7 @@ namespace loaders
         }
 
         dlHandle = module_fromcapsule(pyobj);
-        pfn = (pf_obj * (*)(void)) dlsym(dlHandle, "pf_new");
+        pfn = reinterpret_cast<pf_obj * (*)(void)>(dlsym(dlHandle, "pf_new"));
         if (NULL == pfn)
         {
             PyErr_SetString(PyExc_ValueError, dlerror());