onUnhandledException - fix duplicate logging issue

fysoft2006 · Jul 21, 2015 · f9c82fe · f9c82fe
1 parent 28ca8eb
commit f9c82fe
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/main/java/edu/uci/ics/crawler4j/crawler/WebCrawler.java b/src/main/java/edu/uci/ics/crawler4j/crawler/WebCrawler.java
@@ -219,7 +219,8 @@ protected void onContentFetchError(WebURL webUrl) {
    * @param webUrl URL where a unhandled exception occured
    */
   protected void onUnhandledException(WebURL webUrl, Throwable e) {
-    logger.warn("Unhandled exception while fetching {}: {}", webUrl.getURL(), e.getMessage());
+    String urlStr = (webUrl == null ? "NULL" : webUrl.getURL());
+    logger.warn("Unhandled exception while fetching {}: {}", urlStr, e.getMessage());
     logger.info("Stacktrace: ", e);
     // Do nothing by default (except basic logging)
     // Sub-classed can override this to add their custom functionality
@@ -430,9 +431,6 @@ private void processPage(WebURL curURL) {
     } catch (NotAllowedContentException nace) {
       logger.debug("Skipping: {} as it contains binary content which you configured not to crawl", curURL.getURL());
     } catch (Exception e) {
-      String urlStr = (curURL == null ? "NULL" : curURL.getURL());
-      logger.error("{}, while processing: {}", e.getMessage(), urlStr);
-      logger.debug("Stacktrace", e);
       onUnhandledException(curURL, e);
     } finally {
       if (fetchResult != null) {
@@ -452,4 +450,4 @@ public void setThread(Thread myThread) {
   public boolean isNotWaitingForNewURLs() {
     return !isWaitingForNewURLs;
   }
-}
+}