Tools: Disable visualizer lint to skip generated QT ui code.

fzf123 · Jun 23, 2020 · f866816 · f866816
1 parent adc52f0
commit f866816
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 13 deletions.
diff --git a/modules/tools/visualizer/BUILD b/modules/tools/visualizer/BUILD
@@ -31,6 +31,7 @@ cc_binary(
     ],
 )
 
+# TODO(all): Extract the large library to thin pieces.
 # name, src, hdr, uis = [], res = [], normal_hdrs = [], deps = None
 qt_cc_library(
     name = "visualizer_lib",
@@ -67,4 +68,7 @@ qt_cc_library(
     ],
 )
 
-cpplint()
+# TODO(all): Disable linter temporarily as the generated ui files should be
+# excluded from check. But we should also check the .h and .cc files, if they
+# are extracted to their own cc_libraries. See the TODO above.
+# cpplint()
diff --git a/modules/tools/visualizer/main_window.h b/modules/tools/visualizer/main_window.h
@@ -57,7 +57,7 @@ class MainWindow : public QMainWindow {
  protected:
   void resizeEvent(QResizeEvent*) override;
 
- private slots:
+ private slots:  // NOLINT
   void ActionAddGrid(void);
 
   void ActionOpenPointCloud(void);

diff --git a/modules/tools/visualizer/scene_camera_dialog.h b/modules/tools/visualizer/scene_camera_dialog.h
@@ -44,11 +44,11 @@ class SceneCameraDialog : public QDialog {
   void pitchValueChanged(double);
   void rollValueChanged(double);
 
- public slots:
+ public slots:  // NOLINT
   void updateCameraAttitude(const QVector3D &);
   void updateCameraPos(const QVector3D &);
 
- private slots:
+ private slots:  // NOLINT
   void OnStepSlideChanged(int v);
   void onCameraTypeChanged(int);
 

diff --git a/modules/tools/visualizer/scene_viewer.h b/modules/tools/visualizer/scene_viewer.h
@@ -79,11 +79,11 @@ class SceneViewer : public QOpenGLWidget, protected QOpenGLFunctions {
     }
   }
 
- signals:
+ signals:  // NOLINT
   void CameraPosChanged(const QVector3D& pos);
   void CameraAttitudeChanged(const QVector3D& attitude);
 
- public slots:
+ public slots:  // NOLINT
   void ChangeCameraType(int index);
   //  void ChangeCameraMode(int index);
 

diff --git a/what_works.sh b/what_works.sh
@@ -69,7 +69,8 @@ bazel_build_with_dist_cache \
     //modules/contrib/... \
     //modules/planning/... \
     //modules/perception/... \
-    //modules/third_party_perception/...
+    //modules/third_party_perception/... \
+    //modules/tools/...
 
 bazel_test_with_dist_cache \
     //cyber/... \
@@ -87,7 +88,8 @@ bazel_test_with_dist_cache \
     //modules/guardian/... \
     //modules/map/... \
     //modules/contrib/... \
-    //modules/third_party_perception/...
+    //modules/third_party_perception/... \
+    //modules/tools/...
 
 # Drivers: OK
 bash scripts/install_esdcan_library.sh install
@@ -109,11 +111,6 @@ bazel_test_with_dist_cache $(bazel query //modules/perception/... \
 # //modules/perception/camera/test:camera_lib_lane_postprocessor_denseline_lane_postprocessor_test
 # //modules/perception/camera/test:camera_lib_lane_detector_denseline_lane_detector_test
 
-bazel_build_with_dist_cache //modules/tools/...
-bazel_test_with_dist_cache $(bazel query //modules/tools/... \
-    except //modules/tools/visualizer/... \
-)
-
 # Localization: 3 test failures
 bazel_test_with_dist_cache $(bazel query //modules/localization/... \
     except //modules/localization/ndt/ndt_locator:ndt_lidar_locator_test \