Adding logging for debugibility (cadence-workflow#2802)

* Adding logging for debugibility
gaecom · Nov 8, 2019 · d4308b9 · d4308b9
1 parent cc891e2
commit d4308b9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/common/xdc/nDCHistoryResender.go b/common/xdc/nDCHistoryResender.go
@@ -117,6 +117,11 @@ func (n *NDCHistoryResenderImpl) SendSingleWorkflowHistory(
 	for historyIterator.HasNext() {
 		result, err := historyIterator.Next()
 		if err != nil {
+			n.logger.Error("failed to get history events",
+				tag.WorkflowDomainID(domainID),
+				tag.WorkflowID(workflowID),
+				tag.WorkflowRunID(runID),
+				tag.Error(err))
 			return err
 		}
 		historyBatch := result.(*historyBatch)
@@ -132,6 +137,11 @@ func (n *NDCHistoryResenderImpl) SendSingleWorkflowHistory(
 			historyBatch.versionHistory.GetItems())
 		err = n.sendReplicationRawRequest(replicationRequest)
 		if err != nil {
+			n.logger.Error("failed to replicate events",
+				tag.WorkflowDomainID(domainID),
+				tag.WorkflowID(workflowID),
+				tag.WorkflowRunID(runID),
+				tag.Error(err))
 			return err
 		}
 	}

diff --git a/service/worker/replicator/replicationTask.go b/service/worker/replicator/replicationTask.go
@@ -298,7 +298,9 @@ func (t *activityReplicationTask) Execute() error {
 	return t.historyClient.SyncActivity(ctx, t.req)
 }
 
-func (t *activityReplicationTask) HandleErr(err error) error {
+func (t *activityReplicationTask) HandleErr(
+	err error,
+) error {
 	if t.attempt < t.config.ReplicatorActivityBufferRetryCount() {
 		return err
 	}
@@ -342,7 +344,7 @@ func (t *activityReplicationTask) HandleErr(err error) error {
 			retryV2Err.EndEventId,
 			retryV2Err.EndEventVersion,
 		); resendErr != nil {
-			t.logger.Error("error resend history", tag.Error(err))
+			t.logger.Error("error resend history", tag.Error(resendErr))
 			// should return the replication error, not the resending error
 			return err
 		}
@@ -360,7 +362,9 @@ func (t *historyReplicationTask) Execute() error {
 	return t.historyClient.ReplicateEvents(ctx, t.req)
 }
 
-func (t *historyReplicationTask) HandleErr(err error) error {
+func (t *historyReplicationTask) HandleErr(
+	err error,
+) error {
 	if t.attempt < t.config.ReplicatorHistoryBufferRetryCount() {
 		return err
 	}
@@ -404,7 +408,9 @@ func (t *historyMetadataReplicationTask) Execute() error {
 	)
 }
 
-func (t *historyMetadataReplicationTask) HandleErr(err error) error {
+func (t *historyMetadataReplicationTask) HandleErr(
+	err error,
+) error {
 	retryErr, ok := t.convertRetryTaskError(err)
 	if !ok || retryErr.GetRunId() == "" {
 		return err