Fix NPE for failover query

gaecom · Oct 13, 2020 · eee7337 · eee7337
1 parent 25df2bb
commit eee7337
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/tools/cli/adminFailoverCommands.go b/tools/cli/adminFailoverCommands.go
@@ -172,12 +172,17 @@ func AdminFailoverQuery(c *cli.Context) {
 	if err != nil {
 		ErrorAndExit("Failed to describe workflow", err)
 	}
-	if descResp.WorkflowExecutionInfo.CloseStatus.Equals(shared.WorkflowExecutionCloseStatusTerminated) {
+	if isWorkflowTerminated(descResp) {
 		result.State = failovermanager.WorkflowAborted
 	}
 	prettyPrintJSONObject(result)
 }
 
+func isWorkflowTerminated(descResp *shared.DescribeWorkflowExecutionResponse) bool {
+	return descResp.WorkflowExecutionInfo.CloseStatus != nil &&
+		descResp.WorkflowExecutionInfo.CloseStatus.Equals(shared.WorkflowExecutionCloseStatusTerminated)
+}
+
 // AdminFailoverAbort abort a failover workflow
 func AdminFailoverAbort(c *cli.Context) {
 	client := getCadenceClient(c)