-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jquery.complexify
from everywhere
#13228
Remove jquery.complexify
from everywhere
#13228
Conversation
e48b5d3
to
98d2a34
Compare
@itisAliRH I think we can probably just drop the whole password strength meter? We don't use one on primary galaxy registrations either anymore, and that has been fine. If we do want to pursue this, then we may want to tweak the regexes. And add better feedback as to what the colors mean and what the requirements are in the interface. Something like Again, though, I think we should just remove the 'strength meter' clientside on the toolshed anyway. |
@dannon Yes, that's a good password. No problem. I remove it from the toolshed client :) |
…github.com/itisAliRH/galaxy into Remove-`jquery.complexify`-from-everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR was merged without a "kind/" label, please correct. |
Entirely remove
jquery.complexify
and replace password strength check with vanilla js function by testing regex string.Part of jquery elimination #11939
How to test the changes?
License