Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery.complexify from everywhere #13228

Merged

Conversation

itisAliRH
Copy link
Member

Entirely remove jquery.complexify and replace password strength check with vanilla js function by testing regex string.
Part of jquery elimination #11939

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. enter a password in the toolshed register user page or use forgot password link
    2. if the password is longer than 6 and contains at least one uppercase/lowercase letter and number, strength is medium; if longer than 8 and contain at least one character, strength is strong, else is weak

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@itisAliRH itisAliRH force-pushed the Remove-`jquery.complexify`-from-everywhere branch from e48b5d3 to 98d2a34 Compare January 24, 2022 19:34
@dannon
Copy link
Member

dannon commented Jan 24, 2022

@itisAliRH I think we can probably just drop the whole password strength meter? We don't use one on primary galaxy registrations either anymore, and that has been fine.

If we do want to pursue this, then we may want to tweak the regexes. And add better feedback as to what the colors mean and what the requirements are in the interface. Something like xmAqwvE6Q8pbQp9 comes up orange, but that should be considered strong.

Again, though, I think we should just remove the 'strength meter' clientside on the toolshed anyway.

@itisAliRH
Copy link
Member Author

@dannon Yes, that's a good password. No problem. I remove it from the toolshed client :)

Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dannon dannon merged commit 6df67a9 into galaxyproject:dev Jan 25, 2022
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@dannon dannon mentioned this pull request Jan 25, 2022
14 tasks
@itisAliRH itisAliRH deleted the Remove-`jquery.complexify`-from-everywhere branch January 25, 2022 13:56
@mvdbeek mvdbeek added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants