v1.3.4 processNumericButtonPressed() now checks the PMXPN fit record …

…to get the PIN length
galihlasahido · Dec 1, 2017 · 4c9f978 · 4c9f978
1 parent c399bb8
commit 4c9f978
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,4 +1,5 @@
 December 2017
+  1.3.4 processNumericButtonPressed() now checks the PMXPN fit record to get the PIN length
   1.3.3 Fixed bug with undisplayed numeric data stored in buffer B on state H 
 
 Novemeber 2017

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "electron-atm",
   "productName": "Electron ATM",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "A simple APTRA Advance NDC ATM emulator",
   "main": "main.js",
   "scripts": {

diff --git a/src/controllers/atm.js b/src/controllers/atm.js
@@ -1043,7 +1043,7 @@ class ATM {
     switch(this.current_state.get('type')){
     case 'B':
       this.PIN_buffer += button;
-      if(this.PIN_buffer.length === this.max_pin_length)
+      if(this.PIN_buffer.length === this.FITs.getMaxPINLength(this.card.number) || this.PIN_buffer.length === 6 )
         this.processState(this.current_state.get('number'));
       this.display.insertText(this.PIN_buffer, '*');
       break;

diff --git a/tests/controllers/processPinpadButtonPressed.js b/tests/controllers/processPinpadButtonPressed.js
@@ -32,6 +32,7 @@ test('should put the entered numbers into PIN buffer', t => {
   state.set('number', '230');
   state.set('type', 'B');
   atm.current_state = state;
+  atm.card = {number: '8888999900001111'};
 
   atm.max_pin_length = 6;
   atm.initBuffers();