Skip to content

Commit

Permalink
Merge pull request Ericsson#4236 from bruntib/static_html_relative_link
Browse files Browse the repository at this point in the history
[fix] Links in static HTML files should be relative
  • Loading branch information
vodorok authored May 9, 2024
2 parents 87b2c9b + 2aa4fdb commit 8d1513a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ def create_index_html(self, output_dir: str):
html_report_links.append({'link': html_file, 'report': report})

table_reports = map(lambda data: {
'link': data['link'],
'link': os.path.basename(data['link']),
'file-path': data['report']['fileId'],
'report-hash': data['report']['reportHash'],
'checker-name': data['report']['checker']['name'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,4 +186,10 @@ def test_html_for_inclusion(self):
index_html = os.path.join(output_dir, "index.html")

with open(index_html, 'r', encoding="utf-8", errors="ignore") as f:
self.assertEqual(len(re.findall('"link": "', f.read())), 3)
content = f.read()

# There are 3 reports in the test file.
self.assertEqual(len(re.findall('"link": "', content)), 3)
# The links should be relative so the static HTML folder is
# portable.
self.assertNotIn('"link": "/', content)

0 comments on commit 8d1513a

Please sign in to comment.