Skip to content

Commit

Permalink
Remove automated generation of dwarf index
Browse files Browse the repository at this point in the history
The index is only helpful if the version of GDB to
create it uses the same version as the GDB version
that consumes it. Outside the "local development"
scenario this happens only by conincidence, still
we add ~3.6% to the debug library size and face
maintenance issues like QTBUG-34950.

We also don't see the same performance benefit anymore
with recent versions as we did when the feature was
added, so it's best to not create the index anymore.

People who need it, still can add it manually, or
by the 'gdb-add-index' tool that comes with recent
versions of GDB, or trust their distributors to
set up indexes matching their runtime environment.

Task-number: QTBUG-34950
Change-Id: Id4c79fa51fea9622b0891bd9b9b395b948ecb157
Reviewed-by: Oswald Buddenhagen <[email protected]>
  • Loading branch information
hjk authored and The Qt Project committed Feb 16, 2014
1 parent 2b0f02a commit 9de2853
Show file tree
Hide file tree
Showing 24 changed files with 18 additions and 46 deletions.
2 changes: 1 addition & 1 deletion mkspecs/devices/common/linux_device_pre.conf
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
QT_QPA_DEFAULT_PLATFORM = eglfs

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-archos-gen8-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# http://github.com/KDAB/OpenEmbedded-Archos

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-arm-amlogic-8726M-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-arm-trident-pnx8473-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-beagleboard-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# http://beagleboard.org/

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-maemo-n9-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# http://wiki.qt-project.org/Devices/N9

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

QMAKE_PLATFORM = maemo
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-mipsel-broadcom-97425-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-sh4-stmicro-ST7108-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-sh4-stmicro-ST7540-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/devices/linux-snowball-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# http://qt-project.org/wiki/Snowball

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../../common/linux.conf)
Expand Down
23 changes: 0 additions & 23 deletions mkspecs/features/unix/gdb_dwarf_index.prf

This file was deleted.

1 change: 0 additions & 1 deletion mkspecs/freebsd-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

MAKEFILE_GENERATOR = UNIX
QMAKE_PLATFORM = freebsd bsd
CONFIG += gdb_dwarf_index

QMAKE_CFLAGS_THREAD = -pthread -D_THREAD_SAFE

Expand Down
1 change: 0 additions & 1 deletion mkspecs/freebsd-g++46/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

MAKEFILE_GENERATOR = UNIX
QMAKE_PLATFORM = freebsd bsd
CONFIG += gdb_dwarf_index

QMAKE_CFLAGS_THREAD = -pthread -D_THREAD_SAFE

Expand Down
2 changes: 1 addition & 1 deletion mkspecs/hurd-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

MAKEFILE_GENERATOR = UNIX
QMAKE_PLATFORM = hurd
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

QMAKE_CFLAGS_THREAD += -D_REENTRANT
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/linux-arm-gnueabi-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/linux-g++-32/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

QMAKE_CFLAGS = -m32
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/linux-g++-64/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

QMAKE_CFLAGS = -m64
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/linux-g++-maemo/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

MAKEFILE_GENERATOR = UNIX
QMAKE_PLATFORM = maemo
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
CONFIG += nostrip
QMAKE_INCREMENTAL_STYLE = sublib

Expand Down
2 changes: 1 addition & 1 deletion mkspecs/linux-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../common/linux.conf)
Expand Down
1 change: 0 additions & 1 deletion mkspecs/linux-icc/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += gdb_dwarf_index

QMAKE_COMPILER = gcc intel_icc # icc pretends to be gcc

Expand Down
2 changes: 1 addition & 1 deletion mkspecs/linux-llvm/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../common/linux.conf)
Expand Down
2 changes: 1 addition & 1 deletion mkspecs/linux-lsb-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#

MAKEFILE_GENERATOR = UNIX
CONFIG += incremental gdb_dwarf_index
CONFIG += incremental
QMAKE_INCREMENTAL_STYLE = sublib

include(../common/linux.conf)
Expand Down
1 change: 0 additions & 1 deletion mkspecs/netbsd-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

MAKEFILE_GENERATOR = UNIX
QMAKE_PLATFORM = netbsd bsd
CONFIG += gdb_dwarf_index

QMAKE_COMPILER = gcc

Expand Down
1 change: 0 additions & 1 deletion mkspecs/openbsd-g++/qmake.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

MAKEFILE_GENERATOR = UNIX
QMAKE_PLATFORM = openbsd bsd
CONFIG += gdb_dwarf_index

QMAKE_COMPILER = gcc

Expand Down

0 comments on commit 9de2853

Please sign in to comment.