Skip to content

Commit

Permalink
VMware: name is not required parameter for vmware_guest_custom_attrib…
Browse files Browse the repository at this point in the history
…utes

Fixes: ansible#63222

Signed-off-by: Abhijeet Kasurde <[email protected]>
  • Loading branch information
Akasurde authored and goneri committed Oct 10, 2019
1 parent b3deab4 commit 35cc228
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/vmware_guest_custom_attributes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- vmware_guest_custom_attributes does not require VM name (https://github.com/ansible/ansible/issues/63222).
2 changes: 1 addition & 1 deletion docs/docsite/rst/porting_guides/porting_guide_2.10.rst
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Noteworthy module changes
* :ref:`vmware_host_service_manager <vmware_host_service_manager_module>` now returns ``host_service_status`` instead of Ansible internal key ``results``.
* :ref:`vmware_tag <vmware_tag_module>` now returns ``tag_status`` instead of Ansible internal key ``results``.
* The deprecated ``recurse`` option in :ref:`pacman <pacman_module>` module has been removed, you should use ``extra_args=--recursive`` instead.

* :ref:`vmware_guest_custom_attributes <vmware_guest_custom_attributes_module>` module does not require VM name which was a required parameter for releases prior to Ansible 2.10.

Plugins
=======
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
description:
- Name of the virtual machine to work with.
- This is required parameter, if C(uuid) or C(moid) is not supplied.
required: True
type: str
state:
description:
Expand Down Expand Up @@ -206,7 +205,7 @@ def main():
argument_spec = vmware_argument_spec()
argument_spec.update(
datacenter=dict(type='str'),
name=dict(required=True, type='str'),
name=dict(type='str'),
folder=dict(type='str'),
uuid=dict(type='str'),
moid=dict(type='str'),
Expand Down

0 comments on commit 35cc228

Please sign in to comment.