Skip to content

Commit

Permalink
Fix casing of COMPlus_GCStress variable (dotnet#37828)
Browse files Browse the repository at this point in the history
However, don't set the `COMPlus_GCStress` variable for non-Windows
(bash) scripts, because we don't know if we'll be running on a
platform that supports GCStress (such as macOS, which currently
doesn't support it). All Windows platforms do always support
GCStress in our test runs.
  • Loading branch information
BruceForstall authored Jun 28, 2020
1 parent e1c9ab4 commit 0f7b353
Showing 1 changed file with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,17 @@
<Optimize>True</Optimize>
</PropertyGroup>
<PropertyGroup>
<!-- This test requires GCStress to trigger the regression. Set COMPlus_GCStress here. However,
not all CI platforms support GCStress. In particular, macOS and Alpine do not (currently).
All Windows support GCStress. We don't have any way (currently) to determine if we're
running on a platform that supports GCStress. So, don't set GCStress for non-Windows (Bash).
The test will run under GCStress in normal, scheduled GCStress runs, when only the supported
platforms are run with GCStress.
-->
<CLRTestBatchPreCommands><![CDATA[
$(CLRTestBatchPreCommands)
set COMPlus_GcStress=0xc
set COMPlus_GCStress=0xc
]]></CLRTestBatchPreCommands>
<BashCLRTestPreCommands><![CDATA[
$(BashCLRTestPreCommands)
export COMPlus_GcStress=0xc
]]></BashCLRTestPreCommands>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
Expand Down

0 comments on commit 0f7b353

Please sign in to comment.