Skip to content

Commit

Permalink
Fix cross-compiling argument validation for Linux (dotnet#36368)
Browse files Browse the repository at this point in the history
* Fix cross-compiling argument validation for Linux

dotnet@7c66b6f added a ValidateSet for Windows_NT and Unix even though we don't support building for just "Unix" but for the more concrete OS which is "Linux".

* Update build.ps1
  • Loading branch information
ViktorHofer authored May 14, 2020
1 parent 9924705 commit 91c5fd0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions eng/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Param(
[ValidateSet("Debug","Release","Checked")][string[]][Alias('c')]$configuration = @("Debug"),
[string][Alias('f')]$framework,
[string]$vs,
[ValidateSet("Windows_NT","Unix")][string]$os,
[ValidateSet("Windows_NT","Linux","OSX")][string]$os,
[switch]$allconfigurations,
[switch]$coverage,
[string]$testscope,
Expand All @@ -21,7 +21,7 @@ function Get-Help() {
Write-Host "Common settings:"
Write-Host " -subset Build a subset, print available subsets with -subset help (short: -s)"
Write-Host " -vs Open the solution with VS for Test Explorer support. Path or solution name (ie -vs Microsoft.CSharp)"
Write-Host " -os Build operating system: Windows_NT or Unix"
Write-Host " -os Build operating system: Windows_NT, Linux or OSX"
Write-Host " -arch Build platform: x86, x64, arm or arm64 (short: -a). Pass a comma-separated list to build for multiple architectures."
Write-Host " -configuration Build configuration: Debug, Release or [CoreCLR]Checked (short: -c). Pass a comma-separated list to build for multiple configurations"
Write-Host " -runtimeConfiguration Runtime build configuration: Debug, Release or [CoreCLR]Checked (short: -rc)"
Expand Down

0 comments on commit 91c5fd0

Please sign in to comment.