Skip to content

Commit

Permalink
v2spec minor
Browse files Browse the repository at this point in the history
  • Loading branch information
ahbarnett committed Mar 3, 2020
1 parent cd1c16f commit 3882e1a
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions devel/v2spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ Here nufft_opts is a simple struct, not an object.

finufft_makeplan is passed ptr to opts object, or NULL which uses defaults.

[should finufft_makeplan return a plan object, or a pointer to plan? no]
[should finufft_makeplan return a plan object, or a pointer to plan? no.
Instead it needs an error code, so return that. A ptr to plan is an arg.]



Expand Down Expand Up @@ -116,8 +117,8 @@ Notes on finufftpy.cpp:
// * do we need this cpp module at all - can we interface directly to guru
// cmds in the C++ lib?

[Pass ptr to plan, but py user cannot see inside it. ?
No: copy Joakim's GPU interface plan.
[Pass ptr to plan, but py user cannot see inside it. ? ie, "blind pointer"
No: copy Joakim's GPU interface plan?
]

Detect whether "many" is called in guru (ie, n_transf>1) via shape
Expand All @@ -142,9 +143,11 @@ include
contrib
lib
lib-static
test - direct
examples
python - finufftpy
test - directft
- results
*.refout
examples (C++/C examples)
python - finufftpy (the py module)
- examples
- test
setup.py (this is for pybind11)
Expand Down

0 comments on commit 3882e1a

Please sign in to comment.