Skip to content

Commit

Permalink
wifi: iwlwifi: fix system commands group ordering
Browse files Browse the repository at this point in the history
The commands should be sorted inside the group definition.
Fix the ordering so we won't get following warning:
WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg))

Link: https://lore.kernel.org/regressions/[email protected]/
Link: https://lore.kernel.org/linux-wireless/CAHk-=wix6kqQ5vHZXjOPpZBfM7mMm9bBZxi2Jh7XnaKCqVf94w@mail.gmail.com/
Fixes: b6e3d1b ("wifi: iwlwifi: mvm: implement new firmware API for statistics")
Tested-by: Niklāvs Koļesņikovs <[email protected]>
Tested-by: Damian Tometzki <[email protected]>
Acked-by: Kalle Valo <[email protected]>
Signed-off-by: Miri Korenblit <[email protected]>
Signed-off-by: Emmanuel Grumbach <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Miriam-Rachel authored and torvalds committed Nov 12, 2023
1 parent b57b17e commit e257da5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/intel/iwlwifi/mvm/ops.c
Original file line number Diff line number Diff line change
Expand Up @@ -550,9 +550,9 @@ static const struct iwl_hcmd_names iwl_mvm_system_names[] = {
HCMD_NAME(RFI_CONFIG_CMD),
HCMD_NAME(RFI_GET_FREQ_TABLE_CMD),
HCMD_NAME(SYSTEM_FEATURES_CONTROL_CMD),
HCMD_NAME(RFI_DEACTIVATE_NOTIF),
HCMD_NAME(SYSTEM_STATISTICS_CMD),
HCMD_NAME(SYSTEM_STATISTICS_END_NOTIF),
HCMD_NAME(RFI_DEACTIVATE_NOTIF),
};

/* Please keep this array *SORTED* by hex value.
Expand Down

0 comments on commit e257da5

Please sign in to comment.