Skip to content

Commit

Permalink
Allow specifying the Mac SDK path as an environment variable to //flu…
Browse files Browse the repository at this point in the history
…tter/tools/gn (flutter#8643)

As long as the Mac SDK is i386 ready, engine developers should be able to use the latest version of Xcode to build all artifacts. This issue goes away when gen_snapshot migrates to x64.
  • Loading branch information
chinmaygarde authored Apr 19, 2019
1 parent 30c23e6 commit 7e37080
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tools/gn
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ def to_gn_args(args):

if sys.platform == 'darwin':
gn_args['mac_sdk_path'] = args.mac_sdk_path
if gn_args['mac_sdk_path'] == '':
gn_args['mac_sdk_path'] = os.getenv('FLUTTER_MAC_SDK_PATH', '')

return gn_args

Expand Down Expand Up @@ -294,7 +296,8 @@ def parse_args(args):
parser.add_argument('--no-full-dart-sdk', dest='full_dart_sdk', action='store_false')

parser.add_argument('--mac-sdk-path', default='', type=str,
help='On the mac, the SDK is inferred from the Xcode location unless this flag is specified.')
help='On the mac, the SDK is inferred from the Xcode location unless this flag is specified. ' +
' Setting the FLUTTER_MAC_SDK_PATH environment variable achieves the same effect.')

return parser.parse_args(args)

Expand Down

0 comments on commit 7e37080

Please sign in to comment.