Skip to content

Commit

Permalink
Update comment on Scenic shapes following feedback from schwa423@ (fl…
Browse files Browse the repository at this point in the history
  • Loading branch information
amirh authored Jan 17, 2018
1 parent 4822507 commit d5cd548
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions flow/layers/physical_shape_layer.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ class PhysicalShapeLayer : public ContainerLayer {
} else if (path.isRRect(&frameRRect_)) {
isRect_ = frameRRect_.isRect();
} else {
// Fuchsia's compositor currently only supports rounded rectangle frames.
// Scenic currently doesn't provide an easy way to create shapes from
// arbitrary paths.
// For shapes that cannot be represented as a rounded rectangle we
// default to use the bounding rectangle.
// TODO(amirh): fix this once Fuchsia supports arbitrary shaped frames.
// TODO(amirh): fix this once we have a way to create a Scenic shape from
// an SkPath.
frameRRect_ = SkRRect::MakeRect(path.getBounds());
}
}
Expand Down

0 comments on commit d5cd548

Please sign in to comment.