CI: Bump go version, linters and fix minor issues (thrasher-corp#1010)

* Bump golang, golangci-lint versions and fix issues

* Add -fno-stack-protector

* Fix AppVeyor golangci-lint ver

* Nitters

* Nitters round 2

.appveyor.yml

@@ -36,7 +36,7 @@ services:
 
 init:
   - set PATH=%POSTGRES_PATH%\bin;%PATH%
-  - set PATH=C:\go118\bin;%PATH%
+  - set PATH=C:\go119\bin;%PATH%
 
 install:
   - set Path=C:\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin;%Path%
@@ -55,7 +55,7 @@ before_test:
 
 test_script:
   # test back-end
-  - go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.2
+  - go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.48.0
   - '%GOPATH%\bin\golangci-lint.exe run --verbose'
   - ps: >-
       if($env:APPVEYOR_SCHEDULED_BUILD -eq 'true') {

.github/workflows/linter.yml

@@ -8,8 +8,8 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.18.x'
+          go-version: '1.19.x'
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.46.2
+          version: v1.48.0

.github/workflows/proto-lint.yml

@@ -12,7 +12,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v3
         with:
-          go-version: 1.18.x
+          go-version: 1.19.x
 
       - name: Setup build depends
         run: |

.github/workflows/tests.yml

@@ -1,7 +1,7 @@
 on: [push, pull_request]
 name: CI
 env:
-  GO_VERSION: 1.18.x
+  GO_VERSION: 1.19.x
 jobs:
   backend-psql:
     name: GoCryptoTrader back-end with PSQL
@@ -115,6 +115,7 @@ jobs:
         PSQL_SSLMODE: disable
         GOARCH: 386
         CGO_ENABLED: 1
+        CGO_CFLAGS: -fno-stack-protector
 
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v3

.golangci.yml

@@ -18,12 +18,12 @@ linters:
     - govet
     - ineffassign
     - staticcheck
-    - structcheck
     - typecheck
 #   - unused
 #   - varcheck
 
 # disabled by default linters
+#   - asasalint
     - asciicheck
     - bidichk
     - bodyclose
@@ -38,8 +38,10 @@ linters:
     - errchkjson
     - errname
 #   - errorlint
+    - execinquery
 #   - exhaustive
-#   - exhaustivestruct
+#   - exhaustivestruct // abandoned by its owner, replaced with exhaustruct
+#   - exhaustruct
     - exportloopref
 #   - forbidigo
     - forcetypeassert
@@ -65,7 +67,7 @@ linters:
     - goprintffuncname
     - gosec
     - grouper
-    - ifshort
+#   - ifshort // deprecated by its owner
 #   - importas
 #   - interfacer // deprecated by its owner
 #   - ireturn
@@ -77,24 +79,32 @@ linters:
     - nakedret
 #   - nestif
     - nilerr
+#   - nilnil
 #   - nlreturn
     - noctx
     - nolintlint
+#   - nonamedreturns
+#   - nosnakecase
+    - nosprintfhostport
 #   - paralleltest
     - prealloc
     - predeclared
 #   - promlinter
     - revive
     - rowserrcheck
 #   - scopelint // deprecated since v1.39.0, replaced by exportloopref
-#   - sqlclosecheck
+    - sqlclosecheck
+    - structcheck
     - stylecheck
 #   - tagliatelle
+    - tenv
 #   - testpackage
     - thelper
     - tparallel
     - unconvert
     - unparam
+    - usestdlibvars
+#   - varnamelen
     - wastedassign
     - whitespace
 #   - wrapcheck
@@ -103,8 +113,6 @@ linters:
 linters-settings:
   govet:
     check-shadowing: true
-  golint:
-    min-confidence: 0
   goconst:
     min-occurrences: 6
   depguard:
@@ -139,3 +147,6 @@ issues:
     # The following silences false positives in table tests
     #   https://github.com/kyoh86/scopelint/issues/4
      - Using the variable on range scope `ti` in function literal
+  include: 
+    - EXC0012 # revive: Comment exported (.+) should have comment( \(or a comment on this block\))? or be unexported
+    - EXC0014 # revive: Comment on exported (.+) should be of the form "(.+)..."

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.18 as build
+FROM golang:1.19 as build
 WORKDIR /go/src/github.com/thrasher-corp/gocryptotrader
 COPY . .
 RUN GO111MODULE=on go mod vendor

Makefile

@@ -1,6 +1,6 @@
 LDFLAGS = -ldflags "-w -s"
 GCTPKG = github.com/thrasher-corp/gocryptotrader
-LINTPKG = github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.2
+LINTPKG = github.com/golangci/golangci-lint/cmd/golangci-lint@v1.48.0
 LINTBIN = $(GOPATH)/bin/golangci-lint
 GCTLISTENPORT=9050
 GCTPROFILERLISTENPORT=8085

backtester/common/common_types.go

@@ -20,7 +20,8 @@ const (
 	TradeStr = "trade"
 
 	// DataCandle is an int64 representation of a candle data type
-	DataCandle = iota
+	DataCandle int64 = iota
+	// DataTrade is an int64 representation of a trade data type
 	DataTrade
 )
 

backtester/config/config_test.go

@@ -3,7 +3,6 @@ package config
 import (
 	"encoding/json"
 	"errors"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"testing"
@@ -458,7 +457,7 @@ func TestValidate(t *testing.T) {
 
 func TestReadConfigFromFile(t *testing.T) {
 	tempDir := t.TempDir()
-	passFile, err := ioutil.TempFile(tempDir, "*.start")
+	passFile, err := os.CreateTemp(tempDir, "*.start")
 	if err != nil {
 		t.Fatalf("Problem creating temp file at %v: %s\n", passFile, err)
 	}

backtester/config/configbuilder/main.go

@@ -108,7 +108,7 @@ func main() {
 	yn := quickParse(reader)
 	if yn == y || yn == yes {
 		var fp, wd string
-		extension := "strat" // nolint:misspell // its shorthand for strategy
+		extension := "strat" //nolint:misspell // its shorthand for strategy
 		for {
 			wd, err = os.Getwd()
 			if err != nil {
@@ -427,9 +427,9 @@ func parseDatabase(reader *bufio.Reader, cfg *config.Config) error {
 	}
 	fmt.Println("What is the database Port? eg 1337")
 	input = quickParse(reader)
-	var port float64
+	var port uint64
 	if input != "" {
-		port, err = strconv.ParseFloat(input, 64)
+		port, err = strconv.ParseUint(input, 10, 16)
 		if err != nil {
 			return err
 		}

backtester/data/kline/database/database_test.go

@@ -3,7 +3,6 @@ package database
 import (
 	"errors"
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"testing"
@@ -39,7 +38,7 @@ func TestMain(m *testing.M) {
 	var err error
 	testhelpers.PostgresTestDatabase = testhelpers.GetConnectionDetails()
 	testhelpers.GetConnectionDetails()
-	testhelpers.TempDir, err = ioutil.TempDir("", "gct-temp")
+	testhelpers.TempDir, err = os.MkdirTemp("", "gct-temp")
 	if err != nil {
 		fmt.Printf("failed to create temp file: %v", err)
 		os.Exit(1)
@@ -85,16 +84,7 @@ func TestLoadDataCandles(t *testing.T) {
 	}
 	database.MigrationDir = filepath.Join("..", "..", "..", "..", "database", "migrations")
 	testhelpers.MigrationDir = filepath.Join("..", "..", "..", "..", "database", "migrations")
-	_, err = testhelpers.ConnectToDatabase(&dbConfg)
-	if err != nil {
-		t.Error(err)
-	}
-
-	bot.DatabaseManager, err = engine.SetupDatabaseConnectionManager(&bot.Config.Database)
-	if err != nil {
-		t.Error(err)
-	}
-	err = bot.DatabaseManager.Start(&bot.ServicesWG)
+	conn, err := testhelpers.ConnectToDatabase(&dbConfg)
 	if err != nil {
 		t.Error(err)
 	}
@@ -133,6 +123,10 @@ func TestLoadDataCandles(t *testing.T) {
 	if err != nil {
 		t.Error(err)
 	}
+
+	if err = conn.SQL.Close(); err != nil {
+		t.Error(err)
+	}
 }
 
 func TestLoadDataTrades(t *testing.T) {
@@ -165,16 +159,7 @@ func TestLoadDataTrades(t *testing.T) {
 	}
 	database.MigrationDir = filepath.Join("..", "..", "..", "..", "database", "migrations")
 	testhelpers.MigrationDir = filepath.Join("..", "..", "..", "..", "database", "migrations")
-	_, err = testhelpers.ConnectToDatabase(&dbConfg)
-	if err != nil {
-		t.Error(err)
-	}
-
-	bot.DatabaseManager, err = engine.SetupDatabaseConnectionManager(&bot.Config.Database)
-	if err != nil {
-		t.Error(err)
-	}
-	err = bot.DatabaseManager.Start(&bot.ServicesWG)
+	conn, err := testhelpers.ConnectToDatabase(&dbConfg)
 	if err != nil {
 		t.Error(err)
 	}
@@ -206,6 +191,10 @@ func TestLoadDataTrades(t *testing.T) {
 	if err != nil {
 		t.Error(err)
 	}
+
+	if err = conn.SQL.Close(); err != nil {
+		t.Error(err)
+	}
 }
 
 func TestLoadDataInvalid(t *testing.T) {

backtester/eventhandlers/exchange/slippage/slippage.go

@@ -22,7 +22,7 @@ func EstimateSlippagePercentage(maximumSlippageRate, minimumSlippageRate decimal
 	// eg 80 means for every dollar, keep 80%
 	randSeed := int(minimumSlippageRate.IntPart()) - int(maximumSlippageRate.IntPart())
 	if randSeed > 0 {
-		result := int64(rand.Intn(randSeed)) // nolint:gosec // basic number generation required, no need for crypto/rand
+		result := int64(rand.Intn(randSeed)) //nolint:gosec // basic number generation required, no need for crypto/rand
 
 		return maximumSlippageRate.Add(decimal.NewFromInt(result)).Div(decimal.NewFromInt(100))
 	}

backtester/eventhandlers/strategies/base/base_types.go

@@ -11,7 +11,7 @@ var (
 	// ErrSimultaneousProcessingOnly is raised when a strategy is improperly configured
 	ErrSimultaneousProcessingOnly = errors.New("this strategy only supports simultaneous processing")
 	// ErrStrategyNotFound used when strategy specified in strategy config does not exist
-	ErrStrategyNotFound = errors.New("not found. Please ensure the strategy-settings field 'name' is spelled properly in your .strat config") // nolint:misspell // its shorthand for strategy
+	ErrStrategyNotFound = errors.New("not found. Please ensure the strategy-settings field 'name' is spelled properly in your .strat config") //nolint:misspell // its shorthand for strategy
 	// ErrInvalidCustomSettings used when bad custom settings are found in the strategy config
 	ErrInvalidCustomSettings = errors.New("invalid custom settings in config")
 	// ErrTooMuchBadData used when there is too much missing data

backtester/eventtypes/event/event.go

@@ -77,6 +77,7 @@ func (b *Base) GetReasons() []string {
 	return b.Reasons
 }
 
+// GetBase returns an event base
 func (b *Base) GetBase() *Base {
 	return b
 }

backtester/report/report.go

@@ -138,7 +138,7 @@ func (d *Data) enhanceCandles() error {
 			Asset:     lookup.Asset,
 			Pair:      lookup.Pair,
 			Interval:  lookup.Interval,
-			Watermark: fmt.Sprintf("%s - %s - %s", strings.Title(lookup.Exchange), lookup.Asset.String(), lookup.Pair.Upper()), // nolint // Title usage
+			Watermark: fmt.Sprintf("%s - %s - %s", strings.Title(lookup.Exchange), lookup.Asset.String(), lookup.Pair.Upper()), //nolint // Title usage
 		}
 
 		statsForCandles :=

cmd/apichecker/apicheck.go

@@ -1717,7 +1717,7 @@ func htmlScrapeBitfinex(htmlData *HTMLScrapingData) ([]string, error) {
 	return resp, nil
 }
 
-//  htmlScrapeBinance gets checkstring for binance exchange
+// htmlScrapeBinance gets checkstring for binance exchange
 func htmlScrapeBinance(htmlData *HTMLScrapingData) ([]string, error) {
 	temp, err := sendHTTPGetRequest(htmlData.Path, nil)
 	if err != nil {

cmd/documentation/documentation.go

@@ -486,7 +486,7 @@ func GetPackageName(name string, capital bool) string {
 		i = len(newStrings) - 1
 	}
 	if capital {
-		return strings.Replace(strings.Title(newStrings[i]), "_", " ", -1) // nolint // ignore staticcheck strings.Title warning
+		return strings.Replace(strings.Title(newStrings[i]), "_", " ", -1) //nolint // ignore staticcheck strings.Title warning
 	}
 	return newStrings[i]
 }

cmd/exchange_template/exchange_template.go

@@ -146,7 +146,7 @@ func makeExchange(exchangeDirectory string, configTestFile *config.Config, exch
 
 	fmt.Printf("Output directory: %s\n", exchangeDirectory)
 
-	exch.CapitalName = strings.Title(exch.Name) // nolint:staticcheck // Ignore Title usage warning
+	exch.CapitalName = strings.Title(exch.Name) //nolint:staticcheck // Ignore Title usage warning
 	exch.Variable = exch.Name[0:2]
 	newExchConfig := &config.Exchange{}
 	newExchConfig.Name = exch.CapitalName

cmd/exchange_wrapper_issues/main.go

@@ -878,7 +878,7 @@ func testWrappers(e exchange.IBotExchange, base *exchange.Base, config *Config)
 }
 
 func jsonifyInterface(params []interface{}) json.RawMessage {
-	response, _ := json.MarshalIndent(params, "", " ") // nolint:errchkjson // TODO: ignore this for now
+	response, _ := json.MarshalIndent(params, "", " ") //nolint:errchkjson // TODO: ignore this for now
 	return response
 }
 

cmd/websocket_client/main.go

@@ -5,7 +5,9 @@ import (
 	"errors"
 	"fmt"
 	"log"
+	"net"
 	"net/http"
+	"strconv"
 
 	"github.com/gorilla/websocket"
 	"github.com/thrasher-corp/gocryptotrader/common"
@@ -83,8 +85,8 @@ func main() {
 	}
 
 	listenAddr := cfg.RemoteControl.WebsocketRPC.ListenAddress
-	wsHost := fmt.Sprintf("ws://%s:%d/ws", common.ExtractHost(listenAddr),
-		common.ExtractPort(listenAddr))
+	wsHost := fmt.Sprintf("ws://%s/ws", net.JoinHostPort(common.ExtractHost(listenAddr),
+		strconv.Itoa(common.ExtractPort(listenAddr))))
 	log.Printf("Connecting to websocket host: %s", wsHost)
 
 	var dialer websocket.Dialer