Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable up-face block interaction check #200

Closed

Conversation

ruViolence
Copy link

Added a new configuration option to control whether sitting is allowed only when clicking on the top face of blocks.

Changes:

  • Added new configuration option up-face-only (default: true) in config.yml
  • Modified InteractEvents to check the up-face-only setting before restricting block face interactions
  • Added S_UP_FACE_ONLY field to CManager for configuration handling

Previously, sitting was only allowed when clicking on the top face of blocks. This change makes this behavior configurable, allowing server administrators to decide whether players can sit by clicking on any face of a block or only the top face.

The default setting (true) maintains the original behavior, ensuring backward compatibility.

@gecolay
Copy link
Owner

gecolay commented Jan 15, 2025

The changes look good to me, but I think this feature will not be used that often. Many server owners are already complaining about methods that players abuse to get to higher places with GSit. This configuration option would have to be enabled by the server owner anyway. But since I want to keep the configuration as minimal as possible and include as many frequently used configurations as possible, I would reject this.

@ruViolence
Copy link
Author

I understand your point about keeping the configuration minimal and focusing on the most commonly used options. However, I feel that rejecting this feature might limit server owners’ flexibility and create issues for fair gameplay.

Currently, the restriction to only allow sitting by clicking on the top face of blocks can easily be bypassed by cheats that simulate clicks on the top face. On servers with weaker anti-cheat systems, this restriction becomes ineffective, leaving honest players at a disadvantage while cheaters exploit the system.

Adding this configuration option would give server owners more control to adapt the plugin to their specific needs. Since the default setting keeps the current behavior, there’s no change for those who don’t want to enable it. But for others, having this option could be highly valuable.

In my opinion, it’s better to provide server owners with flexible tools rather than impose a one-size-fits-all approach, especially when the existing restriction doesn’t fully solve the issue.

@gecolay
Copy link
Owner

gecolay commented Jan 31, 2025

Currently, the restriction to only allow sitting by clicking on the top face of blocks can easily be bypassed by cheats that simulate clicks on the top face. On servers with weaker anti-cheat systems, this restriction becomes ineffective, leaving honest players at a disadvantage while cheaters exploit the system.

GSit should not cover the area of ​​responsibility from a anti-cheat plugin. The players without cheats should not have a disadvantage, as the other players with cheats should not exist on the server.

For the reasons mentioned above & in the other post, I will currently reject the PR.
If you want a customized version for GSit, you are welcome to create a fork for your server.

@gecolay gecolay closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants