fix: saveAllIssuers doc says it ignores the brand for known keywords

fixes: 1785
geeksets · Sep 17, 2020 · 88675f5 · 88675f5
1 parent 0880f1c
commit 88675f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/zoe/src/contractSupport/zoeHelpers.js b/packages/zoe/src/contractSupport/zoeHelpers.js
@@ -413,7 +413,7 @@ export async function saveAllIssuers(zcf, issuerKeywordRecord = {}) {
     ([keyword, issuer]) => {
       // If the keyword does not yet exist, add it and the
       // associated issuer.
-      if (issuers.keyword === undefined) {
+      if (issuers[keyword] === undefined) {
         return zcf.saveIssuer(issuer, keyword);
       }
       return undefined;

diff --git a/packages/zoe/test/unitTests/zcf/test-zoeHelpersWZcf.js b/packages/zoe/test/unitTests/zcf/test-zoeHelpersWZcf.js
@@ -175,7 +175,7 @@ test(`zcf saveAllIssuers - already known`, async t => {
   t.is(zcf.getIssuerForBrand(kBrand), kIssuer, 'gelt');
 });
 
-test.failing(`zcf saveAllIssuers - duplicate keyword`, async t => {
+test(`zcf saveAllIssuers - duplicate keyword`, async t => {
   const { zcf } = await setupZCFTest();
 
   const { issuer: pandaIssuer, brand: pandaBrand } = makeIssuerKit('panda');
@@ -187,8 +187,6 @@ test.failing(`zcf saveAllIssuers - duplicate keyword`, async t => {
     MathKind.STRING_SET,
   );
 
-  // TODO: reusing a keyword is documented to ignore it
-  // https://github.com/Agoric/agoric-sdk/issues/1785
   await t.notThrowsAsync(
     () => saveAllIssuers(zcf, { P: pIssuer }),
     'second issuer with same keyword should be ignored.',