Refactor some of the rspec-puppet examples for jenkins::slave to be m…

…ore concise

This reduces some duplication, but also makes sure we have the exact same
branch coverage with the shared_context for both sets of platforms supported by
puppet-jenkins

manifests/slave.pp

@@ -152,8 +152,6 @@
   if $slave_home {
     $fsroot_flag = "-fsroot ${slave_home}"
   }
-  else {$fsroot_flag = ''}
-
 
   # choose the correct init functions
   case $::osfamily {

spec/classes/jenkins_slave_spec.rb

@@ -2,46 +2,47 @@
 
 describe 'jenkins::slave' do
 
-  describe 'RedHat' do
-    let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'CentOS' } }
-
-    describe 'default' do
-      it { should contain_exec('get_swarm_client') }
-      it { should contain_file('/etc/init.d/jenkins-slave') }
-      it { should contain_service('jenkins-slave') }
-      it { should contain_user('jenkins-slave_user').with_uid(nil) }
-      it { should contain_file('/etc/init.d/jenkins-slave').with_content(/-fsroot \/home\/jenkins-slave/) }
-    end
+  shared_context 'a jenkins::slave catalog' do
+    it { should contain_exec('get_swarm_client') }
+    it { should contain_file('/etc/init.d/jenkins-slave') }
+    it { should contain_service('jenkins-slave') }
+    it { should contain_user('jenkins-slave_user').with_uid(nil) }
+    # Let the different platform blocks define  `slave_runtime_file` separately below
+    it { should contain_file(slave_runtime_file).with_content(/-fsroot \/home\/jenkins-slave/) }
 
     describe 'with ssl verification disabled' do
       let(:params) { { :disable_ssl_verification => true } }
-      it { should contain_file('/etc/init.d/jenkins-slave').with_content(/-disableSslVerification/) }
+      it { should contain_file(slave_runtime_file).with_content(/-disableSslVerification/) }
     end
 
     describe 'slave_uid' do
       let(:params) { { :slave_uid => '123' } }
       it { should contain_user('jenkins-slave_user').with_uid(123) }
     end
+
+    describe 'with a non-default $slave_home' do
+      let(:home) { '/home/rspec-runner' }
+      let(:params) { {:slave_home => home } }
+      it { should contain_file(slave_runtime_file).with_content(/-fsroot #{home}/) }
+    end
+  end
+
+  describe 'RedHat' do
+    let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'CentOS' } }
+    let(:slave_runtime_file) { '/etc/init.d/jenkins-slave' }
+
+    it_behaves_like 'a jenkins::slave catalog'
   end
 
   describe 'Debian' do
     let(:facts) { { :osfamily => 'Debian', :lsbdistid => 'debian', :lsbdistcodename => 'natty', :operatingsystem => 'Debian' } }
-    describe 'default' do
-      it { should contain_exec('get_swarm_client') }
-      it { should contain_file('/etc/init.d/jenkins-slave') }
-      it { should contain_service('jenkins-slave') }
-      it { should contain_user('jenkins-slave_user').with_uid(nil) }
-      it { should contain_file('/etc/default/jenkins-slave').with_content(/-fsroot \/home\/jenkins-slave/) }
-    end
-    describe 'with ssl verification disabled' do
-      let(:params) { { :disable_ssl_verification => true } }
-      it { should contain_file('/etc/default/jenkins-slave').with_content(/-disableSslVerification/) }
-    end
+    let(:slave_runtime_file) { '/etc/default/jenkins-slave' }
+
+    it_behaves_like 'a jenkins::slave catalog'
   end
 
   describe 'Unknown' do
     let(:facts) { { :ostype => 'Unknown' } }
     it { expect { should raise_error(Puppet::Error) } }
   end
-
 end