fix the performance issue when calling getHostName (apolloconfig#2152)

geohan · Apr 21, 2019 · ea60157 · ea60157
1 parent 1164038
commit ea60157
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/...-core/src/main/java/com/ctrip/framework/foundation/internals/NetworkInterfaceManager.java b/...-core/src/main/java/com/ctrip/framework/foundation/internals/NetworkInterfaceManager.java
@@ -42,11 +42,16 @@ public InetAddress findValidateIp(List<InetAddress> addresses) {
           weight += 2;
         }
 
+        /**
+         * The following logic is removed as we will sort the network interfaces according to the index asc to determine
+         * the priorities between network interfaces, see https://github.com/ctripcorp/apollo/pull/1986
+         */
         // has host name
-        // TODO fix performance issue when calling getHostName
+        /*
         if (!Objects.equals(address.getHostName(), address.getHostAddress())) {
           weight += 1;
         }
+        */
 
         if (weight > maxWeight) {
           maxWeight = weight;