Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Allow to set a feature limit for WFS #1085

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Jan 22, 2025

Description

This PR introduces a new max_feature_count configuration. This allows to set a limit of WFS features to be displayed on the map, table and chart preview. If a number is set here and a WFS resource exceeds it, the

  • map: will not propose the WFS layer to be displayed (removed from drop-down)
  • table: will paginate the queried data by the max_feature_count number => still todo
  • chart: will not be displayed and show a warning instead

The goal of the PR is to improve performance and display consistent results on big datasets, where the backend might only respond with a limited number of features.

To-dos:

  • paginate table data
  • tests

Architectural changes

The PR has refactored the record-metadata.component and extracted relevant code for the preview section into a record-data-preview.component.

Screenshots

image

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Affected libs: feature-dataviz, feature-record, feature-router, util-app-config, feature-map,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Jan 22, 2025

📷 Screenshots are here!

@tkohr tkohr force-pushed the wfs-dataset-limit branch from f0d8182 to 07f3745 Compare January 22, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant