Skip to content

Commit

Permalink
[AIRFLOW-XXX] Raise ValueError rather than assert in skip logic (apac…
Browse files Browse the repository at this point in the history
  • Loading branch information
AetherUnbound authored and ashb committed Aug 21, 2019
1 parent b7cdedc commit aa8a300
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion airflow/models/skipmixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ def skip(self, dag_run, execution_date, tasks, session=None):
synchronize_session=False)
session.commit()
else:
assert execution_date is not None, "Execution date is None and no dag run"
if execution_date is None:
raise ValueError("Execution date is None and no dag run")

self.log.warning("No DAG RUN present this should not happen")
# this is defensive against dag runs that are not complete
Expand Down

0 comments on commit aa8a300

Please sign in to comment.