disconnect from unicast nodes before raising event

georgkoester · Sep 22, 2012 · d5e11fd · d5e11fd
1 parent aa435a2
commit d5e11fd
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/java/org/elasticsearch/discovery/zen/ping/unicast/UnicastZenPing.java b/src/main/java/org/elasticsearch/discovery/zen/ping/unicast/UnicastZenPing.java
@@ -182,12 +182,12 @@ public void run() {
                     public void run() {
                         sendPings(timeout, TimeValue.timeValueMillis(timeout.millis() / 2), sendPingsHandler);
                         ConcurrentMap<DiscoveryNode, PingResponse> responses = receivedResponses.remove(sendPingsHandler.id());
-                        listener.onPing(responses.values().toArray(new PingResponse[responses.size()]));
+                        sendPingsHandler.close();
                         for (DiscoveryNode node : sendPingsHandler.nodeToDisconnect) {
                             logger.trace("[{}] disconnecting from {}", sendPingsHandler.id(), node);
                             transportService.disconnectFromNode(node);
                         }
-                        sendPingsHandler.close();
+                        listener.onPing(responses.values().toArray(new PingResponse[responses.size()]));
                     }
                 });
             }
@@ -226,7 +226,6 @@ public void close() {
                 executor.shutdownNow();
                 executor = null;
             }
-            nodeToDisconnect.clear();
         }
     }
 
@@ -266,6 +265,9 @@ void sendPings(final TimeValue timeout, @Nullable TimeValue waitTime, final Send
                     @Override
                     public void run() {
                         try {
+                            if (sendPingsHandler.isClosed()) {
+                                return;
+                            }
                             // connect to the node, see if we manage to do it, if not, bail
                             if (!nodeFoundByAddress) {
                                 logger.trace("[{}] connecting (light) to {}", sendPingsHandler.id(), nodeToSend);